[fix][client] Fix ArrayIndexOutOfBoundsException when using SameAuthParamsLookupAutoClusterFailover #23336
Conversation
|
Any chance to add a test case? |
lhotari
changed the title
@poorbarcode @Technoboy- any chance to handle this? |
| @@ -123,7 +130,7 @@ private int firstHealthyPulsarService() { | |||
| } | |||
|
|
|||
| private int findFailoverTo() { | |||
| for (int i = currentPulsarServiceIndex + 1; i <= pulsarServiceUrlArray.length; i++) { | |||
| for (int i = currentPulsarServiceIndex + 1; i < pulsarServiceUrlArray.length; i++) { | |||
There was a problem hiding this comment.
Just wondering if this logic is correct in the first place. Shouldn't this wrap around the array?
the for loop in checkPulsarServices looks strange too.
There was a problem hiding this comment.
The logic of fallover is follows
- if the current cluster is the highest priority cluster and it is healthy, do nothing.
- else if there is a healthy and high priority cluster, recover to the higher priority one.
- else if both current cluster and higher priority clusters are not healthy, find a healthy cluster to fallover to.
So the two method checkPulsarServices and findFailoverTo are for the different cases to same CPU resouces.
checkPulsarServicesis for checking whether their is a healthy and high priority cluster.findFailoverTois for checking whether their has a cluster is healthy.
There was a problem hiding this comment.
@poorbarcode what happens in the case where currentPulsarServiceIndex is already the last one? How can it find a failover cluster in that case?
There was a problem hiding this comment.
what happens in the case where currentPulsarServiceIndex is already the last one? How can it find a failover cluster in that case?
It will transfer to the first healthy cluster. Once encounters the ArrayIndexOutOfBoundsException error, it means no cluster is healthy.
The issue the correct PR solved affects nothing
|
@poorbarcode Do you have a chance to follow up on the review comment? |
Answered here: #23336 (comment) |
…kupAutoClusterFailover
poorbarcode
force-pushed
the
fix/failover_out_of_array
branch
from
8057c39 to
471669d
Compare
|
Rebase master |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23336 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.80%
- Complexity 32624 35036 +2412
============================================
Files 1877 1944 +67
Lines 139502 147334 +7832
Branches 15299 16258 +959
============================================
+ Hits 102638 109583 +6945
- Misses 28908 29286 +378
- Partials 7956 8465 +509
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
There is a mistake in
SameAuthParamsLookupAutoClusterFailover.class, which may cause aArrayIndexOutOfBoundsException, but it affects nothing because it only happens when no server is available.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x