[improve] [pip] PIP-387: Modify interface TopicCompactionService to support cancelling an in-progress compaction task #23462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Upgrade | ||
|
|
||
| If you did not implement a customized `TopicCompactionService` or `Compactor`, it is safety. Otherwise, you need to change your code. |
There was a problem hiding this comment.
It seems to be a break change.
There was a problem hiding this comment.
It's acceptable in a new release. You can see TopicCompactionService is annotated with @InterfaceStability.Evolving.
/**
* Evolving, but can break compatibility at minor release (i.e. m.x)
*/
@Documented
public @interface Evolving {}| + CompactionTaskCtx compact(); | ||
| ``` | ||
|
|
||
| **CompactionTaskCtx.java** |
There was a problem hiding this comment.
This class exposes too many details. Why not just add a cancel() to the TopicCompactionService?
BewareMyPower
requested changes
Nov 1, 2024
There was a problem hiding this comment.
This PIP seems to aim at cancelling an in-progress compaction task. Just changing the interface is not enough. You should add an admin API for it if you want users to cancel a compaction task. Or you must mention when could a compaction task be cancelled if the cancellation is only performed internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x