Skip to content

Conversation

@omarkj
Copy link

@omarkj omarkj commented Feb 6, 2025

Pulsar Client allows callers to create messages with a schema or a transaction, but not both.

This commit adds a new method in the producer that allows callers to create a message with both a schema and transaction.

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Feb 6, 2025
@dao-jun
Copy link
Member

dao-jun commented Feb 7, 2025

@omarkj
Copy link
Author

omarkj commented Feb 7, 2025

PIP PR filed here: #23950, will follow those guidelines by emailing out to the thread soon, etc.

Pulsar Client allows callers to create messages with a schema or a transaction, but
not both. This commit adds a new method in the producer that allows callers to create
a message with both a schema and transaction.
@omarkj omarkj force-pushed the producer-new-message-schema-txn branch from d77ad02 to 59dd60a Compare February 10, 2025 19:16
@omarkj omarkj requested a review from BewareMyPower February 10, 2025 22:35
@lhotari lhotari added this to the 4.1.0 milestone Feb 28, 2025
@lhotari lhotari added area/client type/feature The PR added a new feature or issue requested a new feature area/transaction labels Feb 28, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member

lhotari commented Feb 28, 2025

@BewareMyPower @dao-jun The PIP has been approved and merged, https://github.com/apache/pulsar/blob/master/pip/pip-407.md . PTAL and review

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.20%. Comparing base (669ab61) to head (76d6022).

Files with missing lines Patch % Lines
...va/org/apache/pulsar/client/impl/ProducerBase.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23942      +/-   ##
============================================
+ Coverage     74.18%   74.20%   +0.02%     
+ Complexity    33472    33471       -1     
============================================
  Files          1895     1895              
  Lines        147968   147971       +3     
  Branches      17134    17135       +1     
============================================
+ Hits         109768   109808      +40     
+ Misses        29448    29407      -41     
- Partials       8752     8756       +4     
Flag Coverage Δ
inttests 26.31% <0.00%> (-0.02%) ⬇️
systests 22.71% <0.00%> (+<0.01%) ⬆️
unittests 73.70% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/client/impl/ProducerBase.java 81.48% <66.66%> (-0.88%) ⬇️

... and 84 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari changed the title [improve][client] Add newMessage with schema and transactions [improve][client] PIP-407 Add newMessage with schema and transactions Mar 5, 2025
@coderzc coderzc modified the milestones: 4.1.0, 4.2.0 Sep 1, 2025
@lhotari lhotari dismissed congbobo184’s stale review September 4, 2025 17:31

Unblocking the PR so that we get this finally merged.

@lhotari lhotari merged commit 536dce3 into apache:master Sep 4, 2025
52 checks passed
lhotari pushed a commit that referenced this pull request Sep 8, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client area/transaction cherry-picked/branch-4.1 doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test release/4.1.1 type/feature The PR added a new feature or issue requested a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants