-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][client] PIP-407 Add newMessage with schema and transactions #23942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Producer.java
Show resolved
Hide resolved
|
For PIP process, pls referring to https://github.com/apache/pulsar/tree/master/pip#pulsar-improvement-proposal-pip |
|
PIP PR filed here: #23950, will follow those guidelines by emailing out to the thread soon, etc. |
Pulsar Client allows callers to create messages with a schema or a transaction, but not both. This commit adds a new method in the producer that allows callers to create a message with both a schema and transaction.
d77ad02 to
59dd60a
Compare
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@BewareMyPower @dao-jun The PIP has been approved and merged, https://github.com/apache/pulsar/blob/master/pip/pip-407.md . PTAL and review |
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Producer.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23942 +/- ##
============================================
+ Coverage 74.18% 74.20% +0.02%
+ Complexity 33472 33471 -1
============================================
Files 1895 1895
Lines 147968 147971 +3
Branches 17134 17135 +1
============================================
+ Hits 109768 109808 +40
+ Misses 29448 29407 -41
- Partials 8752 8756 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
Show resolved
Hide resolved
Unblocking the PR so that we get this finally merged.
…#23942) Co-authored-by: Ómar Kjartan Yasin <[email protected]> (cherry picked from commit 536dce3)
…apache#23942) Co-authored-by: Ómar Kjartan Yasin <[email protected]>
…apache#23942) Co-authored-by: Ómar Kjartan Yasin <[email protected]>
Pulsar Client allows callers to create messages with a schema or a transaction, but not both.
This commit adds a new method in the producer that allows callers to create a message with both a schema and transaction.
Documentation
docdoc-requireddoc-not-neededdoc-complete