[fix][ml] Corrected pulsar_storage_size metric to not multiply offloaded storage by the write quorum

[dlg99]

Motivation

I think pulsar_storage_size is partially double-counted. Currently
pulsar_storage_size = pulsar_storage_logical_size * number of replicas

Number of replicas is the same as the bookie write quorum.
pulsar_logical_size doesn't account for the replication, it is sum of customer bytes no matter where they stored at.
and it looks like pulsar_storage_logical_size (calculated here initially) DOES include pulsar_storage_offloaded_size (calculated here).
But the offloaded ledgers (e.g. S3) do not create multiple replicas.

I think the metric should be calculated as:
pulsar_storage_size = pulsar_storage_offloaded_size + (pulsar_storage_logical_size - pulsar_storage_offloaded_size) * number of replicas

Modifications

adjusted calculations of pulsar_storage_size

Verifying this change

• Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: dlg99#22

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.22%. Comparing base (bbc6224) to head (09b589e).
Report is 949 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #24054      +/-   ##
============================================
+ Coverage     73.57%   74.22%   +0.65%     
+ Complexity    32624    32018     -606     
============================================
  Files          1877     1861      -16     
  Lines        139502   144196    +4694     
  Branches      15299    16425    +1126     
============================================
+ Hits         102638   107033    +4395     
+ Misses        28908    28718     -190     
- Partials       7956     8445     +489     

Flag	Coverage Δ
inttests	26.72% <100.00%> (+2.13%)	⬆️
systests	23.08% <0.00%> (-1.24%)	⬇️
unittests	73.74% <100.00%> (+0.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java	89.86% <100.00%> (+0.15%)	⬆️

... and 1058 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lhotari]

LGTM