Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix NPE while publishing Metadata-Event with not init producer #24079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Mar 14, 2025

Motivation

Currently, if broker tries to publish metadata-event before Metadata Event synchronizer is successfully created producer then it throws below NullPointerException and it should be fixed

java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.client.api.Producer.newMessage()" because "this.producer" is null
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:332) ~[?:?]
        at java.base/java.util.concurrent.CompletableFuture.uniApplyNow(CompletableFuture.java:674) ~[?:?]
        at java.base/java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:662) ~[?:?]
        at java.base/java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:2168) ~[?:?]
        at org.apache.pulsar.broker.resources.BaseResources.setAsync(BaseResources.java:151) ~[org.apache.pulsar-pulsar-broker-common-4.jar:4]
        at org.apache.pulsar.broker.resources.NamespaceResources.setPoliciesAsync(NamespaceResources.java:145) ~[org.apache.pulsar-pulsar-broker-common-4.jar:4]
        at org.apache.pulsar.broker.admin.impl.NamespacesBase.setBacklogQuotaAsync(NamespacesBase.java:1343) ~[org.apache.pulsar-pulsar-broker-4.jar:4]
        at org.apache.pulsar.broker.admin.impl.NamespacesBase.lambda$internalSetBacklogQuota$276(NamespacesBase.java:2653) ~[org.apache.pulsar-pulsar-broker-4.jar:4]
        at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1187) ~[?:?]
        at java.base/java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2309) ~[?:?]
        at org.apache.pulsar.broker.admin.impl.NamespacesBase.internalSetBacklogQuota(NamespacesBase.java:2653) ~[org.apache.pulsar-pulsar-broker-4.jar:4]
        at org.apache.pulsar.broker.admin.v1.Namespaces.setBacklogQuota(Namespaces.java:1171) ~[org.apache.pulsar-pulsar-broker-4.jar:4]


Modifications

This PR fixes NPE while publishing metadata event.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/broker doc-not-needed Your PR changes do not impact docs ready-to-test labels Mar 14, 2025
@rdhabalia rdhabalia added this to the 4.1.0 milestone Mar 14, 2025
@rdhabalia rdhabalia self-assigned this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant