-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][schema] Reject unsupported Avro schema types during schema registration #24103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @poorbarcode
I renamed the title to "Reject unsupported Avro schema types during schema registration" since good PR titles are optimally expressed in imperative mood, like good commit messages. The PR title shouldn't be a description of the problem it's fixing. It might be better to file a separate issue where that could be a title of the issue itself. |
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
8fc030a
to
3dc1f4f
Compare
There's a test failure:
It seems that 422 Unprocessable Content status is expected. |
ee4c90d
to
225b9c8
Compare
Motivation
Issue
pulsar-admin
APIAUTO_PRODUCE
schema.Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x