Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 13, 2026

Motivation

Topic list watcher subscribes to metadata store change events and matches the metadata path using a regex. The namespace name part might contain a special character such as . and without escaping, it could match other namespaces that it shouldn't match.

Modifications

Use Pattern.quote to escape the namespace name part in the pattern.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Jan 13, 2026
@lhotari lhotari self-assigned this Jan 13, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 13, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.44%. Comparing base (1617bb2) to head (03f86cd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #25136    +/-   ##
==========================================
  Coverage     74.43%   74.44%            
+ Complexity    34055    33673   -382     
==========================================
  Files          1899     1899            
  Lines        149737   149737            
  Branches      17410    17410            
==========================================
+ Hits         111463   111475    +12     
+ Misses        29388    29380     -8     
+ Partials       8886     8882     -4     
Flag Coverage Δ
inttests 26.31% <0.00%> (+0.05%) ⬆️
systests 23.00% <0.00%> (-0.01%) ⬇️
unittests 73.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...apache/pulsar/broker/resources/TopicResources.java 100.00% <100.00%> (ø)

... and 84 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 1fcdf8b into apache:master Jan 13, 2026
147 of 154 checks passed
Technoboy- pushed a commit that referenced this pull request Jan 14, 2026
coderzc pushed a commit that referenced this pull request Jan 14, 2026
lhotari added a commit that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants