Skip to content

[BUG] Fix stats in PulsarZooKeeperClient multi.#25766

Open
zhaizhibo wants to merge 1 commit into
apache:masterfrom
zhaizhibo:fix_muti_stats
Open

[BUG] Fix stats in PulsarZooKeeperClient multi.#25766
zhaizhibo wants to merge 1 commit into
apache:masterfrom
zhaizhibo:fix_muti_stats

Conversation

@zhaizhibo
Copy link
Copy Markdown
Contributor

Motivation

In PulsarZooKeeperClient.multi(), the stats were incorrectly using createStats instead of multiStats.

Modifications

Changed createStats to multiStats in the multi() method.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

@zhaizhibo
Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun

Copy link
Copy Markdown
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. please add a test to verify we're passing the right stats object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants