[fix][broker] Prevent stale replicator pending reads after termination#25767
Open
Denovo1998 wants to merge 1 commit into
Open
[fix][broker] Prevent stale replicator pending reads after termination#25767Denovo1998 wants to merge 1 commit into
Denovo1998 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
This is a follow-up to #25625 for the replication read-failure path related to #25097.
#25625 completes a replicator
InFlightTaskwhen a managed-ledger read fails, so retryable read failures do not leave stale pending-read state behind. However, there is still a race when the read failure callback arrives after the replicator has already leftStarted, for example during termination or producer restart. In that case,readEntriesFailedreturns before clearing the failedInFlightTask, leavingentries == nulland causinghasPendingRead()to continue treating the old read as active.Modifications
InFlightTaskcontexts before checking whether the replicator is still in theStartedstate.InFlightTaskcontexts whose entries have not already been set.readEntriesFailed.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes