[improve][broker] Skip system cursor when check inactive cursor.#26149
Open
horizonzy wants to merge 1 commit into
Open
[improve][broker] Skip system cursor when check inactive cursor.#26149horizonzy wants to merge 1 commit into
horizonzy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PersistentTopic#checkInactiveSubscriptionsskips built-in system subscriptions such as the compaction subscription when deleting expired inactive subscriptions. However, subscriptions configured throughadditionalSystemCursorNamesare also treated as system cursors elsewhere, but were not skipped by this expiration cleanup path. As a result, an additional system cursor could be deleted when it became inactive past the subscription expiration threshold.Modifications
• Updated
PersistentTopic#checkInactiveSubscriptionsto skip subscriptions identified by isSystemCursor(subName) instead of only checking the compaction subscription.• Extended
PersistentTopicTest#testCheckInactiveSubscriptionsto configure an additionalSystemCursorNames entry and verify that the corresponding subscription is not deleted during inactive subscription cleanup.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes