RANGER-5477:XML External Entity Injection Security issue in Ranger #834
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhavalshah9131
requested review from
dhavalshah9131,
kishorgollapalliwar and
pradeepagrawal8184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request fixes a critical XML External Entity (XXE) injection vulnerability reported by Fortify.
The XML parsing and transformation logic in XmlConfigChanger.java was secured by disabling external entity processing, disallowing DOCTYPE declarations, and enabling secure processing on the TransformerFactory.
How was this patch tested?
Verified successful using: mvn clean compile package install