RATIS-2129. Low replication performance because of lock contention on RaftLog #1322
+87
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blocked by RaftLog's readLock.
Contributor
Author
|
@szetszwo Could you help to review this PR? |
Contributor
|
@symious , this implementation seems to have some bugs. @jojochuang found some failures were observed under stress tests. We need to rework the code. |
Contributor
Author
|
@szetszwo Thank you for the review. Yes, the first commit is your original PR. The second commit is for the fix. |
Contributor
Could you try testing more files (say 1m or 10m) with smaller size(say 1KB) ? BTW, does the Ozone Freon test verify the data? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Details can be found in https://issues.apache.org/jira/browse/RATIS-2129.
The idea is to eliminate the impact of locks to the performance of writing.
The outcome is good. Please check the following table. (CPS: calls/s)
Test running with the following command:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2129
How was this patch tested?
Ozone Freon test.