[Feature][Zeta] Support the tolerable-failed configuration for checkpoints #10223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dybyte
reviewed
Dec 26, 2025
Comment on lines
+296
to
+304
| if (tolerableFailures > 0 && failedCount <= tolerableFailures) { | ||
| LOG.warn( | ||
| "Checkpoint failed (consecutive failures: {}/{}): {}", | ||
| failedCount, | ||
| tolerableFailures, | ||
| ExceptionUtils.getMessage(checkpointException)); | ||
| cleanFailedCheckpoint(reason); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
What happens if a checkpoint fails during a savepoint operation? Is there a possibility that the job become non-responsive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support defines how many consecutive checkpoint failures will be tolerated, before the whole job is failed over. The default value is
0, which means no checkpoint failures will be tolerated, and the job will fail on first reported checkpoint failure.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Add test:
CheckpointCoordinatorTest#testTolerableFailedCheckpoints()Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.