[Fix][Connector-V2] Fix partitioning column selection logic #10236
+96
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dybyte hi,Are all jdbc databases adapted to the leftmost principle？ |
Contributor
Author
Yes. The leftmost column of a composite index is simply the first column defined in the index. |
chl-wxp
reviewed
Dec 26, 2025
.../connector-cdc/connector-cdc-base/src/test/java/jdbc/source/JdbcSourceChunkSplitterTest.java
Show resolved
Hide resolved
.../connector-cdc/connector-cdc-base/src/test/java/jdbc/source/JdbcSourceChunkSplitterTest.java
Outdated
Show resolved
Hide resolved
| if (isEvenlySplitColumn(firstColumn)) { | ||
| splitColumn = columnComparable(splitColumn, firstColumn); | ||
| if (sqlTypePriority(splitColumn) == 1) { | ||
| return splitColumn; |
Member
There was a problem hiding this comment.
How about printing a log after selecting the column, so that users can know some details.
| import java.util.Optional; | ||
|
|
||
| public class JdbcSourceChunkSplitterTest { | ||
| class JdbcSourceChunkSplitterTest { |
Contributor
Author
There was a problem hiding this comment.
JUnit5 does not require test classes to be public, so the modifier was removed as it is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9949
Purpose of this pull request
This PR fixes the partitioning column selection logic.
It ensures that when a primary/unique key is present, the first column of that key is correctly selected and used as the partitioning column.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added
JdbcSourceChunkSplitterTest.splitColumnTestWithUniqueKey().Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.