-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Feature][Connector-V2][Hive] Support multiple Hive metastore URIs for automatic failover #10253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LiJie20190102
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveMetaStoreCatalog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add related doc!
LGTM
+1 if doc is ready
This reads as if failover/DR is assumed by default. I’ve asked the contributor to add a few usage use cases in the write-up to make the expectations explicit. |
…toreClient and add metastore_uri failover example
|
The relevant document content has been added. |
...src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveMetaStoreCatalog.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveMetaStoreCatalog.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveMetaStoreCatalog.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/utils/HiveMetaStoreCatalog.java
Outdated
Show resolved
Hide resolved
corgy-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good pr!
davidzollo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
#10226
Purpose of this pull request
This PR improves Hive connector metastore HA by:
Using RetryingMetaStoreClient (when available) for metastore retry/failover, with a safe fallback to HiveMetaStoreClient.
Supporting comma-separated metastore_uri (with whitespace trimming), so users can configure multiple HMS endpoints for automatic failover.
Fixing HiveServer2 JDBC URL derivation when metastore_uri contains multiple URIs (derive from the first URI only).
Does this PR introduce any user-facing change?
Yes.
metastore_uri now supports multiple HMS URIs separated by commas (whitespace is allowed), and the connector will fail over to the next available metastore if the first one is unreachable.
How was this patch tested?
Unit tests added: HiveMetaStoreCatalogMetastoreUrisTest.java
E2E tests added: HiveIT.java and configs:
fake_to_hive_metastore_uri_failover.conf
hive_to_assert_metastore_uri_failover.conf
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.