[Fix][Connector-V2][ClickHouse] Fix ThreadLocal memory leak in ClickhouseCatalogUtil #10264
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouseCatalogUtil Add PRIMARY_KEY_COLUMNS.remove() in finally block to properly clean up ThreadLocal and prevent memory leak when thread pool reuses threads.
Carl-Zhou-CN
reviewed
Jan 5, 2026
| return super.getCreateTableSql( | ||
| template, database, table, tableSchema, comment, optionsKey); | ||
| } finally { | ||
| pkColumns.clear(); |
Member
There was a problem hiding this comment.
Can this be deleted? There are also 49 lines of clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Add PRIMARY_KEY_COLUMNS.remove() in finally block to properly clean up ThreadLocal and prevent memory leak when thread pool reuses threads.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.