[Feature][Connector-File-Hadoop] Support sync_mode=update for HdfsFile source (binary) #10268
+1,048
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e source (binary)
Comment on lines
+734
to
+757
| private boolean fileContentEquals(String sourceFilePath, String targetFilePath) | ||
| throws IOException { | ||
| try (InputStream sourceIn = hadoopFileSystemProxy.getInputStream(sourceFilePath); | ||
| InputStream targetIn = targetHadoopFileSystemProxy.getInputStream(targetFilePath)) { | ||
| byte[] sourceBuffer = new byte[8 * 1024]; | ||
| byte[] targetBuffer = new byte[8 * 1024]; | ||
|
|
||
| while (true) { | ||
| int sourceRead = sourceIn.read(sourceBuffer); | ||
| int targetRead = targetIn.read(targetBuffer); | ||
| if (sourceRead != targetRead) { | ||
| return false; | ||
| } | ||
| if (sourceRead == -1) { | ||
| return true; | ||
| } | ||
| for (int i = 0; i < sourceRead; i++) { | ||
| if (sourceBuffer[i] != targetBuffer[i]) { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
If it is downgraded to file byte comparison, if the file is large, it may lead to high memory usage. Is there a risk of OOM?
Contributor
Author
There was a problem hiding this comment.
Memory usage here is constant: we compare via streaming reads with two fixed 8KB buffers (no full-file buffering), so large files shouldn’t cause OOM—only more I/O time.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e source (binary)
Purpose of this pull request
Add sync_mode=update to HdfsFile source to only sync new/changed files by comparing source/target (len+mtime or Hadoop getFileChecksum).
Does this PR introduce any user-facing change?
Yes.
New source options: sync_mode/target_path/target_hadoop_conf/update_strategy/compare_mode.
Default behavior unchanged (sync_mode=full).
How was this patch tested?
Unit test (Windows skipped by design; CI Linux will run): mvnw -pl seatunnel-connectors-v2/connector-file/connector-file-base test -Dtest=UpdateSyncModeTest
Added E2E tests (run in CI/Docker env): HdfsFileIT#testHdfsBinaryUpdateModeDistcp / HdfsFileIT#testHdfsBinaryUpdateModeStrictChecksum.
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.