[Bug][Transform-V2] Enable regex replacement by default for FieldRename #10321
+178
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corgy-w
reviewed
Jan 13, 2026
| @@ -13,7 +13,8 @@ FieldRename 用于批量重命名字段名。 | |||
| | convert_case | string | 否 | | 字母大小写转换类型，可选 `UPPER`、`LOWER` | | |||
| | prefix | string | 否 | | 追加到字段名前的前缀 | | |||
| | suffix | string | 否 | | 追加到字段名后的后缀 | | |||
| | replacements_with_regex | array | 否 | | 正则替换规则数组，元素为包含 `replace_from`、`replace_to` 的映射，用于批量替换字段名 | | |||
| | replacements_with_regex | array | 否 | | 替换规则数组，元素为包含 `replace_from`、`replace_to` 以及可选 `is_regex`（默认 `true`）的映射；当 `is_regex=false` 时，`replace_from` 按字段名精确匹配（全匹配） | | |||
| | specific | array | 否 | | 指定字段重命名规则，元素为包含 `field_name` 和 `target_name` 的映射；命中后会直接重命名并跳过其他规则 | | |||
Contributor
There was a problem hiding this comment.
Was this specific missing from the previous document ？
Contributor
Author
There was a problem hiding this comment.
Yes, this parameter is not included in the document, but it actually exists in the code, so we might as well add it here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix FieldRename so replacements_with_regex works as regex by default when is_regex is omitted. Previously is_regex=null was treated as “not regex”, so regex patterns (e.g. lookarounds used for camelCase→snake_case) never applied, leading to unexpected no-op renames and downstream schema/key mismatches (reported in #10317).
Does this PR introduce any user-facing change?
Yes.
Before: if replacements_with_regex items omit is_regex, the rule is treated as a literal full-match, so regex patterns don’t take effect.
After: is_regex defaults to true, so omitted is_regex will apply regex matching.
To keep the old literal behavior, users can explicitly set is_regex = false.
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.