[Feature][Zeta] Unify checkpoint and savepoint restore handling - #11841
Open
JeremyXin wants to merge 3 commits into
Open
[Feature][Zeta] Unify checkpoint and savepoint restore handling#11841JeremyXin wants to merge 3 commits into
JeremyXin wants to merge 3 commits into
Conversation
Route restore decisions through restoreMode so checkpoint restore no longer inherits savepoint-only cleanup and submission behavior. Constraint: Preserve legacy submitJob flag and JobImmutableInformation wire compatibility while fixing restore semantics Rejected: Remove or rename isStartWithSavePoint now | would break compatibility paths and current callers Confidence: medium Scope-risk: narrow Directive: Use restoreMode or isRestoreJob for new restore logic; keep legacy savepoint flag compatibility-only Tested: ./mvnw -pl seatunnel-engine -am spotless:apply -DskipTests Tested: ./mvnw -f seatunnel-engine/seatunnel-engine-core/pom.xml -Dtest=JobImmutableInformationCompatibilityTest -DfailIfNoTests=false test Not-tested: ./mvnw -pl seatunnel-engine/seatunnel-engine-core,seatunnel-engine/seatunnel-engine-server -am -Dtest=JobImmutableInformationCompatibilityTest,CoordinatorServiceJobCleanupTest -DfailIfNoTests=false test | blocked by unrelated seatunnel-common test compilation errors Not-tested: ./mvnw -f seatunnel-engine/seatunnel-engine-server/pom.xml -Dtest=CoordinatorServiceJobCleanupTest -DfailIfNoTests=false test | blocked by sandbox port-bind restriction for Hazelcast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
What does this PR do
restoreModeas the primary restore signal in Zeta restore flowWhy is this needed
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.