Skip to content

Conversation

@xuqi1633
Copy link

@xuqi1633 xuqi1633 commented May 13, 2024

Purpose of this pull request

#6840

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@xuqi1633
Copy link
Author

@liunaijie i have updated test variable

@liunaijie
Copy link
Member

@liunaijie i have updated test variable

Please also update the config. add Assert sink to check the value are expected.

@Hisoka-X Hisoka-X added First-time contributor First-time contributor bugfix labels May 15, 2024
@Hisoka-X Hisoka-X changed the title [Fix-6840] Config variable substitution inconsistent [Fix][Core] Config variable substitution inconsistent May 15, 2024
@Hisoka-X Hisoka-X added this to the 2.3.6 milestone May 15, 2024
@xuqi1633
Copy link
Author

@liunaijie is that so?

@liunaijie
Copy link
Member

image @xuqi1633 the test failed, please check.

@liunaijie
Copy link
Member

liunaijie commented May 15, 2024

image

the change not work, and please also update the other starter script.

@Hisoka-X
Copy link
Member

Hi @xuqi1633 , could you try to fix ci? Thanks

@liunaijie
Copy link
Member

Hi @xuqi1633 , could you try to fix ci? Thanks

i also try this, now the issue is on start script, eg seatunnel.sh.
in this shell command, it can receive right variable, but when it start the java command it will lose the qouta.

@liunaijie liunaijie mentioned this pull request Jul 3, 2024
4 tasks
@Hisoka-X Hisoka-X modified the milestones: 2.3.6, 2.3.7 Jul 25, 2024
@Hisoka-X Hisoka-X modified the milestones: 2.3.7, 2.3.8 Aug 21, 2024
@Hisoka-X Hisoka-X removed this from the 2.3.8 milestone Sep 13, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Jul 13, 2025
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants