-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Fix][Core] Config variable substitution inconsistent #6847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cool, can you also update the existing e2e test. change the sink from console to assert to verify the result are expected. |
|
@liunaijie i have updated test variable |
Please also update the config. add Assert sink to check the value are expected. |
|
@liunaijie is that so? |
@xuqi1633 the test failed, please check.
|
|
Hi @xuqi1633 , could you try to fix ci? Thanks |
i also try this, now the issue is on start script, eg |
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |


Purpose of this pull request
#6840
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.