Skip to content

[Fix][Seatunnel-api]support timestamp type #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

litiliu
Copy link
Contributor

@litiliu litiliu commented Jul 8, 2024

Purpose of this pull request

This close #7125

Does this PR introduce any user-facing change?

How was this patch tested?

add UT case

Check list

@litiliu litiliu marked this pull request as ready for review July 8, 2024 02:48
@Hisoka-X
Copy link
Member

Hisoka-X commented Jul 8, 2024

In fact, SeaTunnel doesn't support Timestamp type at now. We should make sure flink layer not send timestamp type to seatunnel connector. Please refer


cc @TyrantLucifer

@litiliu litiliu closed this Jan 17, 2025
@litiliu litiliu reopened this Mar 25, 2025
@github-actions github-actions bot added api and removed flink labels Mar 25, 2025
@litiliu
Copy link
Contributor Author

litiliu commented Mar 25, 2025

In fact, SeaTunnel doesn't support Timestamp type at now. We should make sure flink layer not send timestamp type to seatunnel connector. Please refer

cc @TyrantLucifer

@Hisoka-X Seems the

has supported the Timestamp type? Could you please explain why it's not supported?

@litiliu litiliu changed the title [Fix][Seatunnel-api]fix timestamp type [Fix][Seatunnel-api]support timestamp type Mar 26, 2025
@litiliu
Copy link
Contributor Author

litiliu commented Mar 27, 2025

@hailin0 PTAL

@litiliu
Copy link
Contributor Author

litiliu commented Mar 27, 2025

@liugddx PTAL

@TyrantLucifer
Copy link
Member

@Hisoka-X In what scenarios will java.sql.Timestamp,I think it maybe connector has some problems. Under normal circumstances, it should be LocalDateTime.

@Hisoka-X
Copy link
Member

Hisoka-X commented Apr 7, 2025

@Hisoka-X In what scenarios will java.sql.Timestamp,I think it maybe connector has some problems. Under normal circumstances, it should be LocalDateTime.

@Hisoka-X In what scenarios will java.sql.Timestamp,I think it maybe connector has some problems. Under normal circumstances, it should be LocalDateTime.

Yep, you talk the point. After #7355, we removed FlinkRowConverter. So all data type came from connector without convert in flink.

@Hisoka-X
Copy link
Member

Hisoka-X commented Apr 7, 2025

@litiliu Please rebase on dev and check we still have same problem or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Seatunnel-api] Unsupported type: Timestamp
3 participants