[Feature]Support enable https protocol for rest-api v2 #8698
Conversation
|
close duplicate PR ？#8599 |
|
close #8583 Please add test cases 
|
|
@hailin0 and what exactly do I have to do for 'Adapt UI' part? |
You can generate it by java code. It is easier to maintain.
Add IT to make sure when use open https port, the UI can get information from server with https port not http port. |
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/pom.xml
Outdated
Show resolved
Hide resolved
| configureServer(); | ||
| } | ||
|
|
||
| private void configureServer() { |
There was a problem hiding this comment.
So we don't support enable https and http at same time. Please add verify to make sure user not open https/http both in config.
| import static org.hamcrest.Matchers.containsString; | ||
|
|
||
| @Slf4j | ||
| public class RestApiHttpsIT { |
There was a problem hiding this comment.
I think we can do some refactoring, such as constructing an AbstractRestAPIIT (move some common code from RestApiIT). Then implement RestApiHttpIT and RestApiHttpsIT both, so that we can verify all functions instead of just getting the UI.
|
|
||
| // Two-way SSL: client presents its certificate. | ||
| @Test | ||
| public void testHttpsTwoWayAuthentication() { |
There was a problem hiding this comment.
add method testHttpsTwoWayAuthenticationFailed
...nnector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/RestApiHttpsIT.java
Outdated
Show resolved
Hide resolved
|
Thanks for the comments @hailin0 |
...engine-common/src/main/java/org/apache/seatunnel/engine/common/config/server/HttpConfig.java
Show resolved
Hide resolved
| .defaultValue("") | ||
| .withDescription("The password for the key in the keystore."); | ||
|
|
||
| public static final Option<Boolean> REQUIRE_CLIENT_AUTH = |
| .withDescription( | ||
| "Whether to require client authentication for HTTPS connections."); | ||
|
|
||
| public static final Option<String> KEY_MANAGER_PASSWORD = |
There was a problem hiding this comment.
what exactly you mean? you want this to be removed?
There was a problem hiding this comment.
unused this field KEY_MANAGER_PASSWORD
...e/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/JettyService.java
Show resolved
Hide resolved
Co-authored-by: Jia Fan <[email protected]>
…e/src/test/java/org/apache/seatunnel/engine/e2e/RestApiHttpsIT.java Co-authored-by: hailin0 <[email protected]>
…che/seatunnel/engine/server/JettyService.java Co-authored-by: hailin0 <[email protected]>
Co-authored-by: Jia Fan <[email protected]>
…e/pom.xml Co-authored-by: Jia Fan <[email protected]>
|
Hi @akulabs8 , why close this PR? |
Purpose of this pull request
Adds Https support to rest api v2
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.