Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Connector-V2] Fix assert connector assertion errors #8746

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Feb 16, 2025

Purpose of this pull request

#8357

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@corgy-w corgy-w marked this pull request as ready for review February 19, 2025 02:41
@Hisoka-X
Copy link
Member

cc @zhangshenghang

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a new check to make sure the assert can throw error normally.

@zhangshenghang
Copy link
Member

Let's add a new check to make sure the assert can throw error normally.

+1 , We need to verify that exceptions can be thrown correctly when an error occurs.

@corgy-w
Copy link
Contributor Author

corgy-w commented Feb 20, 2025

Let's add a new check to make sure the assert can throw error normally.

+1 , We need to verify that exceptions can be thrown correctly when an error occurs.

get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Connector-V2][Assert] AssertSinkWriter supports multiple concurrent operations
3 participants