Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][MongoDB] The Long type cannot handle string values in scientific notation. #8775 #8783

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

[Fix][MongoDB] The Long type cannot handle string values in scientific notation. #8775 #8783

wants to merge 4 commits into from
+85 −1

Conversation

qifanlili
Copy link

Purpose of this pull request

The purpose is to fix bug: 8775

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@qifanlili qifanlili changed the title [Fix][MongoDB] The Long type cannot handle string values in scientific notation. [Fix][MongoDB] The Long type cannot handle string values in scientific notation. #8775 Feb 21, 2025
Hisoka-X
Hisoka-X reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qifanlili ! Could you add a test case in https://github.com/apache/seatunnel/tree/c1b2675ab0826bc90a16766b1811f9f3dc4c2c0c/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb?

qifanlili added a commit to qifanlili/seatunnel that referenced this pull request Mar 4, 2025
@qifanlili
[Fix][MongoDB] The Long type cannot handle string values in scientifi…
b53368c 
…c notation. (apache#8783)
qifanlili added 2 commits March 4, 2025 16:15
@qifanlili
parent a3a7b49
ea92505 
author lee <[email protected]> 1740121208 +0800
committer lee <[email protected]> 1741076125 +0800

parent a3a7b49
author lee <[email protected]> 1740121208 +0800
committer lee <[email protected]> 1741076105 +0800

[Fix][MongoDB] The Long type cannot handle string values in scientific notation. (apache#8783)
@qifanlili
[Fix][MongoDB] The Long type cannot handle string values in scientifi…
d7515e1 
…c notation.
@github-actions github-actions bot added document core SeaTunnel core module and removed mongodb labels Mar 4, 2025
@qifanlili
Copy link
Author

Thanks @qifanlili ! Could you add a test case in https://github.com/apache/seatunnel/tree/c1b2675ab0826bc90a16766b1811f9f3dc4c2c0c/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb?

Okay, I've submitted it.

@qifanlili
Copy link
Author

@Hisoka-X Any other questions here?

Hisoka-X
Hisoka-X reviewed Mar 25, 2025
View reviewed changes
...rg/apache/seatunnel/connectors/seatunnel/mongodb/source/split/SamplingSplitStrategyTest.java
Comment on lines +76 to +78
Method method = SamplingSplitStrategy.class.getDeclaredMethod("getDocumentNumAndAvgSize");
method.setAccessible(true);
ImmutablePair<Long, Long> result = (ImmutablePair<Long, Long>) method.invoke(strategy);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to use reflection to test your code. Let's set getDocumentNumAndAvgSize scope to default and add @VisibleForTesting annotation. Then you can invoke it in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
connectors-v2 mongodb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qifanlili @Hisoka-X