Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DynamoDb] Dynamodb client supports endpointOverride and create credentials from container or system env. #8858

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

joyCurry30
Copy link
Contributor

@joyCurry30 joyCurry30 commented Feb 27, 2025

Purpose of this pull request

In AWS DynamoDB, the endpoint can be overridden, meaning the region is not required. AWS services can automatically derive the endpoint based on the region, making the url parameter optional as well. Additionally, when retrieving credentials for DynamoDB, it is possible to obtain them directly from the container, which will automatically scan the system’s environment variables for the necessary parameters.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@joyCurry30
Copy link
Contributor Author

Hi @liunaijie @hailin0 @Hisoka-X, could you please review this PR? Any feedback would be greatly appreciated! Thanks a lot!

@joyCurry30
Copy link
Contributor Author

@liunaijie
Copy link
Member

wait for ci pass

@joyCurry30
Copy link
Contributor Author

I just update doc. Remove the ambiguous description of 'url'.

…ating credentials from container or system env.
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joyCurry30 ! Please add test case in

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants