-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][DynamoDb] Dynamodb client supports endpointOverride and create credentials from container or system env. #8858
base: dev
Are you sure you want to change the base?
Conversation
3f57888
to
18d4d79
Compare
Hi @liunaijie @hailin0 @Hisoka-X, could you please review this PR? Any feedback would be greatly appreciated! Thanks a lot! |
...org/apache/seatunnel/connectors/seatunnel/amazondynamodb/sink/AmazonDynamoDBSinkFactory.java
Outdated
Show resolved
Hide resolved
...apache/seatunnel/connectors/seatunnel/amazondynamodb/source/AmazonDynamoDBSourceFactory.java
Show resolved
Hide resolved
As credentials, refer to https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/credentials-providers.html |
wait for ci pass |
I just update doc. Remove the ambiguous description of 'url'. |
…ating credentials from container or system env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joyCurry30 ! Please add test case in
Line 97 in b5e5d00
public void testAmazondynamodb(TestContainer container) throws Exception { |
Purpose of this pull request
In AWS DynamoDB, the endpoint can be overridden, meaning the region is not required. AWS services can automatically derive the endpoint based on the region, making the url parameter optional as well. Additionally, when retrieving credentials for DynamoDB, it is possible to obtain them directly from the container, which will automatically scan the system’s environment variables for the necessary parameters.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.