[Feature][JDBC] Support database/table wildcards scan read #8869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corgy-w
reviewed
Feb 28, 2025
...a/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/sqlserver/SqlServerCatalogTest.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/JdbcUrlUtil.java
Outdated
Show resolved
Hide resolved
4 tasks
Hisoka-X
reviewed
Mar 3, 2025
Comment on lines
+64
to
+66
| default Logger getLogger() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
print logs matched tables
default List<CatalogTable> getTables(ReadonlyConfig config) throws CatalogException {
...
if (getLogger() != null) {
if (tablePaths.isEmpty()) {
getLogger().info("No table matched the pattern: {}", tablePatternStr);
} else {
getLogger()
.info(
"{} tables matched the pattern: {}",
tablePaths.size(),
tablePatternStr);
}
}
return buildCatalogTablesWithErrorCheck(tablePaths.iterator());
}
| List<TablePath> tablePaths = new ArrayList<>(); | ||
| for (String databaseName : allDatabase) { | ||
| tableNames = this.listTables(databaseName); | ||
| boolean isOracle = "Oracle".equals(this.name()); |
There was a problem hiding this comment.
We should not do this kind special check in api.
Comment on lines
36
to
50
| public final class JdbcUrlUtil { | ||
| private static final Pattern URL_PATTERN = | ||
| Pattern.compile( | ||
| "^(?<url>jdbc:.+?//(?<host>.+?):(?<port>\\d+?))(/(?<database>.*?))*(?<suffix>\\?.*)*$"); | ||
|
|
||
| private static final Pattern SQLSERVER_URL_PATTERN = | ||
| Pattern.compile( | ||
| "^(?<url>jdbc:sqlserver://([a-zA-Z0-9.-]+)(?::(\\d+))?(;(?<param>[^=]+)\\s*=(?<value>[^;]+);?)*)$"); | ||
|
|
||
| private static final Pattern ORACLE_URL_PATTERN = | ||
| Pattern.compile( | ||
| "^(?<url>jdbc:oracle:thin:@(//)?(?<host>[^:]+):(?<port>\\d+))(/(?<database>.*?))*(?<suffix>\\?.*)*$"); | ||
|
|
||
| private static final Pattern HANA_URL_PATTERN = | ||
| Pattern.compile("^(?<url>jdbc:sap://(?<host>[^:]+):(?<port>\\d+)/?(?<params>.*?))$"); |
There was a problem hiding this comment.
Change JdbcUrlUtil as abstract class? Then each implement class can hold pattern by themself.
3 tasks
hawk9821
force-pushed
the
jdbc_wildcards
branch
8 times, most recently
from
964752d to
72e8dc4
Compare
[Fix][Connector-V2] Fix parse SqlServer JDBC Url error (apache#8784)
hawk9821
force-pushed
the
jdbc_wildcards
branch
from
72e8dc4 to
1e7f193
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
this pr support databse : mysql ， oracle， postgres， mssql
close #8473
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.