[Bug] [connector-jdbc-kingbase]Error in Jdbc Source with Kingbase8: Unsupported Field Data Types (e.g., smallint) during Catalog Table Lookup #8866 #8874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 → smallint, int4 → int, int8 → bigint) in JDBC Mapping
|
@Hisoka-X The KingbaseTypeConverterTest has been updated; please review it. |
Hisoka-X
reviewed
Mar 4, 2025
| @@ -89,7 +89,7 @@ public void testConvertBoolean() { | |||
| @Test | |||
| public void testConvertSmallint() { | |||
| BasicTypeDefine<Object> typeDefine = | |||
| BasicTypeDefine.builder().name("test").columnType("int2").dataType("int2").build(); | |||
| BasicTypeDefine.builder().name("test").columnType("smallint").dataType("smallint").build(); | |||
There was a problem hiding this comment.
Please do not change existed test.
…o standard SQL names, ensuring KingbaseTypeConverter aligns with JDBC behavior.
|
@Hisoka-X My apologies for modifying the existing code; it has been reverted. Please review the newly submitted code. |
|
Please fix test case. |
|
@Hisoka-X I have updated the test case to comply with Spotless's rules. Please review the changes and let me know if further modifications are needed. |
|
Please retry failed ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Kingbase Database Column Type Mapped as Standard SQL Types (e.g., int2 → smallint, int4 → int, int8 → bigint) in JDBC Mapping
close #8866
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.