[Feature][Transform] support boolean type for sql transform #9136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/SQLTransformTest.java:321
- [nitpick] Consider renaming the test method to 'testCaseWhenBooleanClausesWithField' for clarity and consistency with naming conventions.
public void tesCaseWhenBooleanClausesWithField() {
seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/SQLTransformTest.java:356
- [nitpick] Consider renaming the test method to 'testCastBooleanClausesWithField' for clarity and consistency with naming conventions.
public void tesCastBooleanClausesWithField() {
...forms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/SystemFunction.java
Outdated
Show resolved
Hide resolved
hawk9821
force-pushed
the
transform_boolean
branch
from
600c9b5 to
3ebd933
Compare
|
cc @hailin0 |
|
Please update the doc. |
Hisoka-X
reviewed
Apr 14, 2025
Comment on lines
268
to
272
| if (("true".equalsIgnoreCase(columnExp.getColumnName()) | ||
| || "false".equalsIgnoreCase(columnExp.getColumnName())) | ||
| && ("CaseWhenExpression".equalsIgnoreCase(node.toString()))) { | ||
| return Boolean.parseBoolean(columnExp.getColumnName()); | ||
| } |
There was a problem hiding this comment.
Why not directly return StringValue in here? Then parse it to boolean in cast method.
There was a problem hiding this comment.
Comment on lines
118
to
123
| Node node = columnExp.getASTNode().jjtGetParent(); | ||
| if (("true".equalsIgnoreCase(columnExp.getColumnName()) | ||
| || "false".equalsIgnoreCase(columnExp.getColumnName())) | ||
| && ("CaseWhenExpression".equalsIgnoreCase(node.toString()))) { | ||
| return BasicType.BOOLEAN_TYPE; | ||
| } |
hawk9821
force-pushed
the
transform_boolean
branch
from
aed02df to
b2fed4e
Compare
Hisoka-X
approved these changes
Apr 21, 2025
hailin0
approved these changes
Apr 21, 2025
hawk9821
added a commit
to hawk9821/seatunnel
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
support boolean type for sql transform. eg:
select ( case when
col1= 'a' then true else false end ) asbool_1, cast(col2as boolean) asbool_2asbool_2from dualnote:
cast column value must is (1,0) or ('true','false')
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.