Skip to content

[Fix][Common] Problems with comma-separated logic in variable values during variable substitution.(#9151) #9170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

qifanlili
Copy link
Contributor

Purpose of this pull request

The purpose is to fix bug: #9151

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the api label Apr 14, 2025
@Hisoka-X Hisoka-X linked an issue Apr 15, 2025 that may be closed by this pull request
3 tasks
@Hisoka-X
Copy link
Member

I prefer remove quotes when parse string from command. Let's update

@github-actions github-actions bot added core SeaTunnel core module and removed api labels Apr 15, 2025
@qifanlili
Copy link
Contributor Author

I prefer remove quotes when parse string from command. Let's update

Thank you for your suggestions and please review my new revisions!

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer add token into stringbuilder instead of filter it after stringbuilder build.
https://github.com/apache/seatunnel/pull/9170/files#diff-ed7f2c6884e1b28b24e5f78741c61d9d6fe4082fc5f7f06b06f75778e6fed86eR48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core SeaTunnel core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Common] 变量替换时,变量值中存在逗号的分隔逻辑问题
2 participants