Skip to content

[improve] pulsar options #9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@davidzollo davidzollo requested a review from Copilot April 16, 2025 02:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/PulsarSource.java:84

  • The admin configuration is being set using CLIENT_SERVICE_URL instead of ADMIN_SERVICE_URL. It should retrieve the admin URL from PulsarSourceOptions.ADMIN_SERVICE_URL to ensure the correct endpoint is used.
PulsarAdminConfig.builder().adminUrl(config.get(PulsarSourceOptions.CLIENT_SERVICE_URL));

@nielifeng nielifeng requested a review from Copilot April 16, 2025 07:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/sink/PulsarSinkWriter.java:80

  • The transactionTimeout value is set directly from the configuration without an explicit default. Ensure that PulsarSinkOptions.TRANSACTION_TIMEOUT is defined with a proper default to avoid runtime nulls.
this.transactionTimeout = pluginConfig.get(PulsarSinkOptions.TRANSACTION_TIMEOUT);

seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/config/PulsarConfigUtil.java:171

  • [nitpick] Consider using getOptional() for PulsarSinkOptions.PULSAR_CONFIG for consistency with the new configuration style.
if (pluginConfig.get(PulsarSinkOptions.PULSAR_CONFIG) != null) {

seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java:194

  • Verify that the removal of 'PulsarSinkOptions' and 'PulsarSourceOptions' from the whitelist is intentional, as they are still referenced in the connector code and this change might affect connector option validations.
whiteList.add("PulsarSinkOptions");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant