-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Feature] Add RPM generation support #9181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Pass -Drpm.build.disable=false to enable RPM generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- seatunnel-dist/pom.xml: Language not supported
- seatunnel-dist/sbin/seatunnel: Language not supported
- seatunnel-dist/src/main/assembly/assembly-bin-ci.xml: Language not supported
By default rpm generation is disabled. Pass -Drpm.build.disable=false to enable RPM generation |
</sources> | ||
</mapping> | ||
</mappings> | ||
<postinstallScriptlet> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a preInstallScriptlet, /usr/bigtop, which is defined as an rpm root, may not be present,
<preInstallScriptlet>
<![CDATA[
#!/bin/bash
mkdir -p /usr/bigtop
]]>
</preInstallScriptlet>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the installation of the RPM, if the rpm.stack.root directory (which is configurable but defaults to /usr/bigtop) does not exist, the yum install command will create it and then copy the necessary files and folders into it. Since we access the rpm.stack.root after the installation, it is guaranteed that the stack root will always be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the clarification, if we can accommodate in RPM installation guide, it would be helpulf, -Drpm.stack.root=/usr/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will add the documentation later as part of resolving task #9196
LGTM |
Pass -Drpm.build.disable=false to enable RPM generation
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.