Skip to content

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Apr 28, 2025

Purpose of this pull request

Fix losing checkpoint scheduling in extreme cases. For example, clock drift.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@github-actions github-actions bot added the Zeta label Apr 28, 2025
@nielifeng nielifeng requested a review from Copilot April 29, 2025 01:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes an issue with losing checkpoint scheduling in edge cases by refining the checkpoint trigger logic and logging messages.

  • Updated logging messages to use parameterized placeholders.
  • Introduced an additional check to ensure all tasks are ready before triggering a checkpoint.
  • Adjusted the scheduling logic for final checkpoint types.

Hisoka-X and others added 6 commits April 29, 2025 10:07
@github-actions github-actions bot added the e2e label May 6, 2025
@Hisoka-X Hisoka-X marked this pull request as ready for review May 6, 2025 09:41
@jiamin13579
Copy link
Contributor

I also encountered this problem

@corgy-w corgy-w merged commit 3783816 into apache:dev May 13, 2025
5 checks passed
dybyte pushed a commit to dybyte/seatunnel that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants