Skip to content

[improve] sls options #9260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the configuration options for the SLS connector by replacing legacy Config references with dedicated options classes, thereby consolidating configuration definitions and ensuring consistency between source and sink components.

  • Replace legacy Config references with SlsSourceOptions, SlsSinkOptions, and SlsBaseOptions.
  • Update configuration retrieval in source, sink, and factory classes.
  • Remove whitelist entries for SLS options in ConnectorOptionCheckTest to validate the new configuration classes.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/source/SlsSourceFactory.java Updated to use SlsSourceOptions for configuration.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/source/SlsSourceConfig.java Replaced legacy Config with SlsSourceOptions while constructing consumer metadata.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/source/SlsSource.java Updated plugin name retrieval to use SlsBaseOptions.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java Retrieved sink configuration values from SlsSinkOptions.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkFactory.java Updated required and optional options to SlsSinkOptions.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSink.java Updated plugin name reference to SlsBaseOptions.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/config/SlsSourceOptions.java Refactored source options by extending SlsBaseOptions.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/config/SlsSinkOptions.java Introduced dedicated sink options.
seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/config/SlsBaseOptions.java Centralized common SLS configuration options.
seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java Removed whitelist entries for SLS options to align with the updated configuration classes.
Comments suppressed due to low confidence (2)

seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java:195

  • The removal of the whitelist entry for SlsSinkOptions reflects the configuration refactor; please ensure that related test documentation is updated to clarify this change.
whiteList.add("SlsSinkOptions");

seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java:197

  • The removal of the whitelist entry for SlsSourceOptions is in line with the new configuration classes; consider updating any related test documentation to reflect this change.
whiteList.add("SlsSourceOptions");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant