Skip to content

[improve] sentry options #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@nielifeng nielifeng requested a review from Copilot May 6, 2025 06:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the Sentry connector’s options usage by replacing the legacy Config with the newer ReadonlyConfig and SentrySinkOptions, and updates related factory and test files accordingly.

  • Refactored SentrySinkWriter and SentrySink to use ReadonlyConfig and SentrySinkOptions.
  • Updated SentrySinkFactory to reference SentrySinkOptions.
  • Adjusted test expectations in ConnectorOptionCheckTest.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySinkWriter.java Replaced legacy Config with ReadonlyConfig and updated option getters.
seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySinkFactory.java Updated to use SentrySinkOptions constants and added sink creation method.
seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySink.java Removed the prepare method and injected CatalogTable along with ReadonlyConfig.
seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/config/SentrySinkOptions.java Changed option types from String to their respective types (Boolean, Integer, Long).
seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java Removed SentrySinkOptions from whitelist.
Comments suppressed due to low confidence (1)

seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java:199

  • The removal of 'SentrySinkOptions' from the whitelist may result in configuration validation issues during testing; please confirm that this omission is intentional and does not impact test coverage of the Sentry connector.
whiteList.add("SentrySinkOptions");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant