[Feature][Connector-V2] MongodbSink Support SaveMode #9883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll hang this pull request here first, and I'll optimize and supplement it later, as well as add unit tests and E2E |
look forward to |
| DataSaveMode.class, | ||
| Arrays.asList(DROP_DATA, APPEND_DATA, ERROR_WHEN_DATA_EXISTS)) | ||
| .defaultValue(APPEND_DATA) | ||
| .withDescription("data_save_mode"); |
There was a problem hiding this comment.
Add a description of him instead of copying the name
docs/en/connector-v2/sink/MongoDB.md
Outdated
| | common-options | | No | - | Source plugin common parameters, please refer to [Source Common Options](../sink-common-options.md) for details | | ||
| | data_save_mode | String | No | APPEND_DATA | The data saving mode of mongodb | | ||
|
|
||
| ### data_save_mode [Enum] |
There was a problem hiding this comment.
Describing him in the "Description" section of the table would be more in line with the previous format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide