-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Improve][Transform-V2][Embedding]Enhance multimodal embeddings #9996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
loupipalien
wants to merge
18
commits into
apache:dev
Choose a base branch
from
loupipalien:enhance-multimodal-embeddings
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a5d4773
enhance multimodal embeddings
loupipalien 39891eb
fix: fix VectorFieldSpecTest test case
loupipalien 6ffbfa0
chore: add spotless toggleOffOn
loupipalien 96df9e6
chore: code format
loupipalien ce90e41
chore:remove deduplicated code
loupipalien af4e659
chore: modify comment
loupipalien a1c423b
fix: fix set isMultimodalFileds
loupipalien a80f4a3
test: upgrade testcontainers for docker test
loupipalien a63baef
chore: add log
loupipalien 439778a
fix: use reference filter instead of image name filter
loupipalien 050c8f9
chore: increase connector-file-local-it job timeout
loupipalien 84a09e5
fix: fix some bugs and add docs
loupipalien 3464cbb
chore: increase all-connectors-it-1 job timeout
loupipalien f1f54d9
chore: update docs and remove unnecessary comment
loupipalien 408ac92
modify: create a new object avoid to share SrcFieldSpec
loupipalien 8941cc9
chore: revert testcontainer version and ci timeout minutes
loupipalien 8e139c5
chore: revert to image name filter
loupipalien 2d0f9da
chore: remove spotless toggleOffOn
loupipalien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isMultimodalFields = vectorFieldSpec.isMultimodalField();
There is a logical issue; currently, only the last value can be obtained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loupipalien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time, let me fix it