2.1.5 #2479
Open
2.1.5 #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 11, 2025 17:58
- 添加 BatchJob 接口，定义获取和处理数据的方法 - 实现 BatchJobExecutor以支持批处理作业的执行- 在 JobExecutorFactory 中增加对 BatchJob 的支持 - 优化 LiteJob 类，通过 JobDataMap 传递 elasticJob 和 jobFacade- 更新 SchedulerFacade，使用异步方式启动和停止 reconcileService - 升级 guava 版本至 16.0.1
linghengqian
requested changes
Sep 12, 2025
Member
linghengqian
left a comment
linghengqian
left a comment
There was a problem hiding this comment.
Why did you delete the LICENSE file?
There was a problem hiding this comment.
Pull request overview
This pull request removes multiple JavaScript library files and custom console JavaScript files from the elastic-job-cloud-scheduler's console resources directory. The PR title "2.1.5" suggests this is a version-related change, though the description lacks detail about the motivation for these deletions.
Key Changes
- Complete removal of third-party library files (daterangepicker, bootstrap, bootstrap-table, BootstrapValidator, AdminLTE)
- Deletion of all custom console JavaScript files for job and app management functionality
- Removal of CSS files for the removed libraries
Reviewed changes
Copilot reviewed 128 out of 1060 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| daterangepicker.js | Removed daterangepicker library (v2.1.24) |
| daterangepicker.css | Removed daterangepicker styling |
| bootstrap/js/npm.js | Removed Bootstrap npm module configuration |
| bootstrap/js/bootstrap.js | Removed Bootstrap JavaScript library (v3.3.4) |
| bootstrap-table files | Removed bootstrap-table library and Chinese localization |
| bootstrapValidator_zh_CN.js | Removed Chinese localization for Bootstrap Validator |
| AdminLTE CSS files | Removed AdminLTE theme styling (minified versions) |
| job/*.js | Removed all job management JavaScript files (overview, add, modify, common) |
| history/*.js | Removed all history-related JavaScript files (dashboard, execution details/status) |
| app/*.js | Removed all app management JavaScript files (common, modify) |
| common.js | Removed shared utility functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request: