Skip to content

fix: fix checkstatus post req and resp body#454

Merged
sandynz merged 3 commits into
apache:mainfrom
mlycore:fix-checkstatus
Nov 14, 2023
Merged

fix: fix checkstatus post req and resp body#454
sandynz merged 3 commits into
apache:mainfrom
mlycore:fix-checkstatus

Conversation

@mlycore
Copy link
Copy Markdown
Contributor

@mlycore mlycore commented Nov 14, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • Should use req.Body to makeup request body
  • Should use a common response data type for possible response handling

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

Signed-off-by: mlycore <miaoliyao@apache.org>
Signed-off-by: mlycore <miaoliyao@apache.org>
@mlycore mlycore added this to the 0.4.0 milestone Nov 14, 2023
@github-actions github-actions Bot added the pitr solutions of pitr label Nov 14, 2023
Signed-off-by: mlycore <miaoliyao@apache.org>
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 874 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (3eb8c04) 36.31%.
Report is 189 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...rdingsphere-operator/pkg/kubernetes/pod/builder.go 0.00% 118 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/agent/internal/pkg/opengauss.go 2.70% 36 Missing ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
...hardingsphere-operator/pkg/kubernetes/resources.go 0.00% 28 Missing ⚠️
...ere-operator/pkg/kubernetes/container/container.go 31.25% 22 Missing ⚠️
shardingsphere-operator/pkg/kubernetes/helpers.go 46.15% 20 Missing and 1 partial ⚠️
...perator/pkg/controllers/compute_node_controller.go 0.00% 20 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   39.71%   36.31%   -3.41%     
==========================================
  Files          51       59       +8     
  Lines        6083     6617     +534     
==========================================
- Hits         2416     2403      -13     
- Misses       3448     3987     +539     
- Partials      219      227       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandynz sandynz merged commit 8fcdf3c into apache:main Nov 14, 2023
@mlycore mlycore deleted the fix-checkstatus branch November 14, 2023 10:45
mlycore added a commit to mlycore/shardingsphere-on-cloud that referenced this pull request Nov 15, 2023
* fix: fix typo DBBackModeFull

* fix: fix checkstatus post req and resp body

* chore: update backup test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pitr solutions of pitr type: fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants