Skip to content

refactor: optimize backup return message while cancelled#468

Merged
sandynz merged 1 commit into
apache:mainfrom
mlycore:optimize-cancel
Nov 20, 2023
Merged

refactor: optimize backup return message while cancelled#468
sandynz merged 1 commit into
apache:mainfrom
mlycore:optimize-cancel

Conversation

@mlycore
Copy link
Copy Markdown
Contributor

@mlycore mlycore commented Nov 18, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

  • Reduce unnecessary log messages while the backup is cancelled.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

Signed-off-by: mlycore <miaoliyao@apache.org>
@github-actions github-actions Bot added the pitr solutions of pitr label Nov 18, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mlycore mlycore added this to the 0.4.0 milestone Nov 18, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 810 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (18931f3) 36.70%.
Report is 206 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/cli/internal/cmd/delete.go 61.41% 38 Missing and 11 partials ⚠️
pitr/agent/internal/pkg/opengauss.go 2.56% 38 Missing ⚠️
pitr/cli/internal/cmd/backup.go 55.26% 32 Missing and 2 partials ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
pitr/cli/internal/pkg/local-storage.go 22.58% 14 Missing and 10 partials ⚠️
...ere-operator/pkg/kubernetes/container/container.go 31.25% 22 Missing ⚠️
shardingsphere-operator/pkg/kubernetes/helpers.go 46.15% 20 Missing and 1 partial ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   39.71%   36.70%   -3.01%     
==========================================
  Files          51       61      +10     
  Lines        6083     6813     +730     
==========================================
+ Hits         2416     2501      +85     
- Misses       3448     4069     +621     
- Partials      219      243      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandynz sandynz merged commit fcd8dcc into apache:main Nov 20, 2023
@mlycore mlycore deleted the optimize-cancel branch November 20, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pitr solutions of pitr type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants