Skip to content

refactor: add PrettyPrinter to print backup progress#470

Merged
tristaZero merged 5 commits into
apache:mainfrom
mlycore:pretty-print
Nov 20, 2023
Merged

refactor: add PrettyPrinter to print backup progress#470
tristaZero merged 5 commits into
apache:mainfrom
mlycore:pretty-print

Conversation

@mlycore
Copy link
Copy Markdown
Contributor

@mlycore mlycore commented Nov 20, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

  • Abstract a PrettyPrinter to print progress

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

Signed-off-by: mlycore <miaoliyao@apache.org>
Signed-off-by: mlycore <miaoliyao@apache.org>
Signed-off-by: mlycore <miaoliyao@apache.org>
Signed-off-by: mlycore <miaoliyao@apache.org>
Signed-off-by: mlycore <miaoliyao@apache.org>
@github-actions github-actions Bot added the pitr solutions of pitr label Nov 20, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mlycore mlycore added this to the 0.4.0 milestone Nov 20, 2023
@tristaZero tristaZero merged commit bb1f000 into apache:main Nov 20, 2023
@mlycore mlycore deleted the pretty-print branch November 20, 2023 11:47
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.19149% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.49%. Comparing base (3604a24) to head (f64ab8e).
⚠️ Report is 257 commits behind head on main.

Files with missing lines Patch % Lines
pitr/cli/pkg/prettyoutput/progress.go 8.51% 43 Missing ⚠️
pitr/cli/internal/cmd/backup.go 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   39.71%   36.49%   -3.23%     
==========================================
  Files          51       60       +9     
  Lines        6083     6837     +754     
==========================================
+ Hits         2416     2495      +79     
- Misses       3448     4099     +651     
- Partials      219      243      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pitr solutions of pitr type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants