Skip to content

feat: add Init before AddInstance while backing up#480

Merged
mlycore merged 1 commit into
apache:mainfrom
mlycore:fix-init
Dec 15, 2023
Merged

feat: add Init before AddInstance while backing up#480
mlycore merged 1 commit into
apache:mainfrom
mlycore:fix-init

Conversation

@mlycore
Copy link
Copy Markdown
Contributor

@mlycore mlycore commented Dec 15, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Using gs_probackup init to init dn-backup-path before AddInstance

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

Signed-off-by: mlycore <miaoliyao@apache.org>
@mlycore mlycore added the pitr solutions of pitr label Dec 15, 2023
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlycore mlycore added this to the 0.4.0 milestone Dec 15, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 15, 2023

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.81%. Comparing base (3604a24) to head (8cb6480).
⚠️ Report is 257 commits behind head on main.

Files with missing lines Patch % Lines
pitr/agent/internal/handler/backup.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   39.71%   36.81%   -2.90%     
==========================================
  Files          51       60       +9     
  Lines        6083     6945     +862     
==========================================
+ Hits         2416     2557     +141     
- Misses       3448     4142     +694     
- Partials      219      246      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pitr solutions of pitr type: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants