Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add p6spy driver support to ShardingJDBC infra #31814

Merged
merged 2 commits into from
Jun 22, 2024
Merged

add p6spy driver support to ShardingJDBC infra #31814

merged 2 commits into from
Jun 22, 2024

Conversation

lcjing
Copy link
Contributor

@lcjing lcjing commented Jun 22, 2024

Fixes #31782 .

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

linghengqian
linghengqian reviewed Jun 22, 2024
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The PR did not pass the code formatting validation. You can execute first ./mvnw spotless:apply -Pcheck -T1C. Then execute ./mvnw checkstyle:check -Pcheck -T1C to manually adjust to repair the CI.

infra/database/type/p6spy/pom.xml Outdated Show resolved Hide resolved
...rc/main/java/org/apache/shardingsphere/infra/database/p6spy/type/P6spyMySQLDatabaseType.java Show resolved Hide resolved
linghengqian
linghengqian approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linghengqian linghengqian added this to the 5.5.1 milestone Jun 22, 2024
@linghengqian linghengqian merged commit c12a657 into apache:master Jun 22, 2024
141 checks passed
jiangML pushed a commit to jiangML/shardingsphere that referenced this pull request Jun 24, 2024
@lcjing @jiangML
Add p6spy driver support to ShardingJDBC infra (apache#31814)
d63a8e5 
* add p6spy driver support to ShardingJDBC infra

* remove unnecessary dependency and testcontainers modify
@linghengqian linghengqian mentioned this pull request Nov 8, 2024
Closed
@linghengqian linghengqian mentioned this pull request Dec 14, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghengqian linghengqian linghengqian approved these changes

Assignees
No one assigned
Labels
in: infra type: enhancement
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

ShardingJDBC is not supported p6spy driver，add p6spy driver support to ShardingJDBC infra
2 participants
@lcjing @linghengqian