Column bind update in with segment bind #34384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Yash-cor, can you update release note? |
Yes Sir |
Hello @strongduanmu I have updated the release notes. |
…nto COLUMN_BIND_IN_WITH_SEGMENT_BIND Resolve Release Notes Merge Conflict.
…' into COLUMN_BIND_IN_WITH_SEGMENT_BIND
strongduanmu
requested changes
Jan 22, 2025
...n/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/WithSegmentBinder.java
Outdated
Show resolved
Hide resolved
strongduanmu
requested changes
Jan 22, 2025
.../shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java
Show resolved
Hide resolved
…ion segment from WithSegmentBinder to CommonTableExpressionBinder.
…/Yash-cor/shardingsphere into COLUMN_BIND_IN_WITH_SEGMENT_BIND Resolves Merge Conflict in Release Notes.
…nto COLUMN_BIND_IN_WITH_SEGMENT_BIND
|
@strongduanmu I think the label should be bug as it causes ColumnNotFoundException when we define column names while using with segment. |
Obviously, the SQL Bind logic of the WITH statement is still under development, and setting the label to enhancement is more in line with the actual situation. |
strongduanmu
requested changes
Feb 7, 2025
.../shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
While using With Clause when Column definition is added it caused Column not found exception.
Added DifferenceInColumnCountOfSelectListAndColumnNameListException to handle difference in Column counts.
Made correction in column bind and externalTableBinderContext in CommonTableExpressionBinder.
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.