Column bind update in with segment bind

[Yash-cor]

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

While using With Clause when Column definition is added it caused Column not found exception.
Added DifferenceInColumnCountOfSelectListAndColumnNameListException to handle difference in Column counts.
Made correction in column bind and externalTableBinderContext in CommonTableExpressionBinder.

---

Before committing this PR, I'm sure that I have checked the following options:

• My code follows the code of conduct of this project.
• I have self-reviewed the commit code.
• I have (or in comment I request) added corresponding labels for the pull request.
• I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
• I have made corresponding changes to the documentation.
• I have added corresponding unit tests for my changes.
• I have updated the Release Notes of the current development version. For more details, see Update Release Note

[strongduanmu]

Hi @Yash-cor, can you update release note?

[Yash-cor]

Hi @Yash-cor, can you update release note?

Yes Sir

[Yash-cor]

Hi @Yash-cor, can you update release note?

Hello @strongduanmu I have updated the release notes.

[strongduanmu]

Can you move this logic to CommonTableExpressionSegmentBinder?

[Yash-cor]

Hello @strongduanmu while changing the logic I found Error in the way WithSegment is handling Recursive segment of with clause.

• Recursive segment allows user to use the same common table expression ( cte ) name in cte's subquery
  Example -

   WITH RECURSIVE cte  AS
  (
     SELECT 1 as (n)
     UNION ALL
     SELECT n + 1 FROM cte WHERE n < 5
  )
  SELECT * FROM cte;
  

  or similarly can be written as

  WITH RECURSIVE cte (n) AS
  (
     SELECT 1
     UNION ALL
     SELECT n + 1 FROM cte WHERE n < 5
  )
  SELECT * FROM cte;
  

• The WITH clause must begin with WITH RECURSIVE if any CTE in the WITH clause refers to itself. (If no CTE refers to itself, RECURSIVE is permitted but not required.) We have to include a check for it.

• The recursive CTE subquery has two parts, separated by UNION ALL or UNION DISTINCT. Thus, a recursive CTE consists of a non-recursive SELECT part followed by a recursive SELECT part. Should i include a check for it as this check happens when the query hits the MySQL database.

[Yash-cor]

Can you move this logic to CommonTableExpressionSegmentBinder?

I have added this logic in CommonTableExpressionSegmentBinder inside the recursion condition.

[strongduanmu]

Please add column-bound expected result.

[Yash-cor]

I have added the column-bound info

[strongduanmu]

Please check it again, these columns need call ColumnSegmentBinder

[Yash-cor]

These changes help in ColumnSegmentBind

[strongduanmu]

Can you check SQLStatementAssert to confirm whether these columns have been asserted?

[Yash-cor]

Yes I have checked these asserts.

[Yash-cor]

Hello @strongduanmu could you give any updates on this PR.

[Yash-cor]

@strongduanmu I think the label should be bug as it causes ColumnNotFoundException when we define column names while using with segment.

[strongduanmu]

@strongduanmu I think the label should be bug as it causes ColumnNotFoundException when we define column names while using with segment.

Obviously, the SQL Bind logic of the WITH statement is still under development, and setting the label to enhancement is more in line with the actual situation.

[strongduanmu]

Please remove result.getColumns().addAll(segment.getColumns()); and result.getColumns().clear();, they seem meaningless.

[Yash-cor]

Thanks for reply @strongduanmu
This segment result.getColumns().addAll(segment.getColumns()); and result.getColumns().clear(); are needed for creating ExternalTableBinderContexts.
ExternalTableBinderContexts need the result with Column Segment and binded SubqueryTableSegment.
And in order to perform column bind for CommonTableExpressionSegment we need the updated ExternalTableBinderContexts.