-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Column bind update in with segment bind #34384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column bind update in with segment bind #34384
Conversation
Hi @Yash-cor, can you update release note? |
Yes Sir |
Hello @strongduanmu I have updated the release notes. |
…nto COLUMN_BIND_IN_WITH_SEGMENT_BIND Resolve Release Notes Merge Conflict.
…' into COLUMN_BIND_IN_WITH_SEGMENT_BIND
...n/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/WithSegmentBinder.java
Outdated
Show resolved
Hide resolved
.../shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java
Show resolved
Hide resolved
…ion segment from WithSegmentBinder to CommonTableExpressionBinder.
…/Yash-cor/shardingsphere into COLUMN_BIND_IN_WITH_SEGMENT_BIND Resolves Merge Conflict in Release Notes.
…nto COLUMN_BIND_IN_WITH_SEGMENT_BIND
@strongduanmu I think the label should be bug as it causes ColumnNotFoundException when we define column names while using with segment. |
Obviously, the SQL Bind logic of the WITH statement is still under development, and setting the label to enhancement is more in line with the actual situation. |
.../shardingsphere/infra/binder/engine/segment/dml/with/CommonTableExpressionSegmentBinder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merged.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
While using With Clause when Column definition is added it caused Column not found exception.
Added DifferenceInColumnCountOfSelectListAndColumnNameListException to handle difference in Column counts.
Made correction in column bind and externalTableBinderContext in CommonTableExpressionBinder.
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.