Skip to content

Column bind update in with segment bind #34384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 10, 2025

Conversation

Yash-cor
Copy link
Contributor

@Yash-cor Yash-cor commented Jan 17, 2025

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

While using With Clause when Column definition is added it caused Column not found exception.
Added DifferenceInColumnCountOfSelectListAndColumnNameListException to handle difference in Column counts.
Made correction in column bind and externalTableBinderContext in CommonTableExpressionBinder.


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@strongduanmu
Copy link
Member

Hi @Yash-cor, can you update release note?

@Yash-cor
Copy link
Contributor Author

Hi @Yash-cor, can you update release note?

Yes Sir

@Yash-cor
Copy link
Contributor Author

Hi @Yash-cor, can you update release note?

Hello @strongduanmu I have updated the release notes.

@Yash-cor Yash-cor requested a review from strongduanmu January 22, 2025 10:19
@Yash-cor Yash-cor marked this pull request as draft January 24, 2025 06:43
@Yash-cor Yash-cor marked this pull request as ready for review January 24, 2025 09:58
@Yash-cor Yash-cor requested a review from strongduanmu January 24, 2025 09:58
@Yash-cor Yash-cor marked this pull request as draft January 27, 2025 06:12
@Yash-cor Yash-cor marked this pull request as ready for review January 27, 2025 06:12
@Yash-cor
Copy link
Contributor Author

Yash-cor commented Feb 7, 2025

@strongduanmu I think the label should be bug as it causes ColumnNotFoundException when we define column names while using with segment.

@strongduanmu
Copy link
Member

@strongduanmu I think the label should be bug as it causes ColumnNotFoundException when we define column names while using with segment.

Obviously, the SQL Bind logic of the WITH statement is still under development, and setting the label to enhancement is more in line with the actual situation.

@Yash-cor Yash-cor requested a review from strongduanmu February 7, 2025 10:08
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

@strongduanmu strongduanmu merged commit 807a1bd into apache:master Feb 10, 2025
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants