Fix order dependent test in Resilience4JPluginTest #6261
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes an order-dependent (OD) flaky test in
Resilience4JPluginTestby preventingnormalTestfrom being affected by fallback execution triggered inrateLimiterTest.Resilience4JPluginTestcontains three tests:rateLimiterTest(polluter)circuitBreakerTestnormalTest(victim)In
rateLimiterTest, the following line executes a real Resilience4J rate-limiter error:This forces the RateLimiterExecutor to execute the Resilience4J rate-limiter error path and fallback logic. So when normalTest runs after it, fallback is executed again, violating verifyComplete() and causing an order-dependent failure.
The Fix
The fix mocks
RateLimiterExecutor.run()in normalTest to returnMono.empty(), this prevents execution of the Resilience4J rate-limiter error path and fallback logic, ensuringnormalTestcompletes normally regardless of test execution order.Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.