-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore(3.x): Migrate to jakarta EE 10 using OpenRewrite #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.x
Are you sure you want to change the base?
Conversation
Thank you once again @rgcv It would be great if you could give exact commands that you ran to get to this PR. This way I can independently reproduce this PR and check the (much smaller) diffs manually. Can you please do that? This would greatly simplify and speed up the review process. |
Sure thing! There was mostly just one, responsible for the first commit alone, which was ./mvnw -U org.openrewrite.maven:rewrite-maven-plugin:run \
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE \
-Drewrite.activeRecipes=org.openrewrite.java.migrate.jakarta.JakartaEE10 \
-Drewrite.exportDatatables=true as per https://docs.openrewrite.org/recipes/java/migrate/jakarta/jakartaee10#usage. The commits following that were man-made, after running a series of |
Awesome, thank you! I think will finally have a way forward with the ability to properly review now. |
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager
,where you replace
#XXX
with the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXX
if merging the PR should close a related issue.mvn verify
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i
.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager
.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Based on the overall complex changes introduced by #2017 (and discussion within it) and #2018, I decided to open a more concise PR that runs the OpenRewrite Jakarta EE 10 migration recipe.
As a result, the base commit is the changeset introduced by applying the recipe. Surrounding commits handle a few things manually, such as
jakarta
classifier from shiro artifacts + shade-plugin configurationcheckstyle
issues resulting from the migrationHttpSessionContext
polyfill and related code (gone in EE10)Regarding the last bullet point, perhaps even per supported module/feature-set, a few more changes are required. Plus, some decisions might want to be made before proceeding with migration, namely: