feat: add recover to goroutine to prevent unexpected panics#226
Conversation
|
Could you explain why panic in this case? If there is any code bug, we should fic them rather than recovering. |
|
I haven’t identified the root cause yet. Many services in our production environment are integrated with SkyWalking, but no similar issues have been observed in other services. Just before the service panic, a large number of error logs were printed: |
|
We should merge this directly. Instead, we should try to analyze why. Because, if it is a predicted case, we should process it properly. |
|
Currently, I'm unable to reproduce the issue with a demo. Since we cannot guarantee the safety of goroutines, every goroutine must have a recover . |
|
Please update the CHANGES.md file. |
The documentation has been updated. |
The online service experienced a panic after integrating SkyWalking.
SkyWalking’s panic should not affect the normal operation of the service.
Each goroutine should be guarded with a recover function.
Currently, many goroutines in the codebase are missing recover protection.
panic log