Fix LAL rule missing layer property in oapserverconfig e2e test#177
Merged
wu-sheng merged 1 commit intoapache:masterfrom Feb 27, 2026
Merged
Conversation
The latest OAP requires a top-level 'layer' property in LAL rules. Without it, the rule is ignored and log_count metrics are never produced, causing log_count_info verification to fail.
kezhenxu94
approved these changes
Feb 27, 2026
wu-sheng
added a commit
to apache/skywalking-helm
that referenced
this pull request
Feb 27, 2026
Fix SWCK oapserverconfig e2e test for latest OAP compatibility Two issues prevented the oapserverconfig test from passing with the latest OAP images: 1. OAPServerConfig spec.version (9.5.0) didn't match OAPServer (latest), so the SWCK operator never applied the config and the pod was never restarted, causing a timeout. 2. The LAL rule from SWCK v0.9.0 was missing the layer property required by the latest OAP, so log_count metrics were never produced and log_count_info verification failed with all-zero values. This was fixed upstream in apache/skywalking-swck#177. Switch from SWCK v0.9.0 to the latest commit (e98e180) which includes the LAL layer fix, and add sed to align the version field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layer: GENERALproperty in LAL rules. Theoapserverconfig-demo.yamle2e test file is missing this property, causing the LAL rule to be silently ignored by the latest OAP server.log_countmetrics are never produced and thelog_count_infoverification fails with all-zero values.Changes
layer: GENERALto the LAL rule intest/e2e/oapserverconfig-demo.yamlHow this was found
The skywalking-helm e2e tests were updated to use the latest OAP images instead of 9.5.0. The
oapserverconfigtest began failing because the custom LAL rule from this file lacked thelayerproperty required by the latest OAP.