fix: bump Go dependencies to address CVEs#183
Merged
kezhenxu94 merged 6 commits intoapache:masterfrom Mar 20, 2026
Merged
Conversation
- google.golang.org/grpc v1.61.0 → v1.79.3 (CVE-2026-33186) - go.opentelemetry.io/otel/sdk v1.22.0 → v1.40.0 (CVE-2026-24051) - Go 1.25.5 → 1.25.8 (CVE-2026-25679, CVE-2026-27142)
There was a problem hiding this comment.
Pull request overview
Updates the adapter module’s Go toolchain version directive and dependency graph to remediate reported CVEs (notably in google.golang.org/grpc and go.opentelemetry.io/otel/sdk).
Changes:
- Bumped adapter module’s Go version directive to
1.25.8. - Updated key vulnerable Go dependencies (e.g.,
google.golang.org/grpc,go.opentelemetry.io/otel/sdk) and related transitive modules. - Refreshed
go.sumto match the updated module resolution.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| adapter/go.mod | Updates Go version directive and bumps vulnerable dependencies to newer versions. |
| adapter/go.sum | Updates checksum entries to reflect the new resolved dependency versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,6 +1,6 @@ | |||
| module github.com/apache/skywalking-swck/adapter | |||
|
|
|||
There was a problem hiding this comment.
This PR updates the Go version directive in adapter/go.mod to 1.25.8 to address stdlib CVEs, but the repo still has another module pinned to 1.25.5 (operator/go.mod). If the patch-level Go bump is required for the CVE remediation, please bump the Go version consistently across all Go modules (or document why only the adapter module needs it).
Suggested change
| // This module explicitly targets Go 1.25.8 to pick up stdlib CVE fixes. | |
| // Other modules in this repo (e.g., operator) may remain on 1.25.5 if they | |
| // do not build binaries or exercise the affected stdlib code paths. |
- Fix adapter/go.mod: use 'go 1.25' + 'toolchain go1.25.8' (patch version not valid in go directive) - Fix E2E: upgrade Elasticsearch 7.5.1 → 8.18.8 and add xpack.security.enabled=false since ES 8 enables security by default
cert-manager v1.8.0 (EOL since 2023) was causing e2e test failures where the skywalking-swck-system operator pod never became Ready. The root cause is that cert-manager v1.8.0's admission webhook appears to fail silently in newer GitHub Actions runner environments (ubuntu-latest updated since March 2026), preventing the Certificate resource from being processed and the TLS secret from being issued. cert-manager v1.11.5 is the latest version compatible with Kubernetes v1.21.10 (used by kind in the e2e tests).
kustomize edit set image with a tagless image name leaves the existing newTag (v0.8.0) in config/manager/kustomization.yaml intact, causing the operator deployment to request controller:v0.8.0 while kind only has controller:latest loaded — resulting in ImagePullBackOff and the pod never becoming Ready. Using controller:latest explicitly forces kustomize to set newTag:latest, ensuring the locally loaded image is used.
Add actions/upload-artifact@v4 on failure to all e2e jobs so logs are preserved for debugging. Only the internal-storage job had this before.
gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0 is no longer accessible (gcr.io Container Registry was deprecated). The project moved to quay.io/brancz/kube-rbac-proxy. Updating to v0.18.1 from the correct registry fixes ErrImagePull for the operator sidecar.
mrproliu
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump vulnerable Go dependencies in the adapter module to address multiple CVEs:
google.golang.org/grpcv1.61.0 → v1.79.3go.opentelemetry.io/otel/sdkv1.22.0 → v1.40.0Changes
adapter/go.modandadapter/go.sumwith bumped dependenciesCGO_ENABLED=0 go build ./...