-
Notifications
You must be signed in to change notification settings - Fork 736
SOLR-6122 POC new cancel handler for Collections api #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCancelMessageHandler.java
Show resolved
Hide resolved
…eerCancelMessageHandler.java Co-authored-by: Christine Poerschke <[email protected]>
@dsmiley hi David, you might be interested in this PR |
I might be interested but I confess I'm very biased to see the Overseer die. Adding a feature to it is the opposite of that. |
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
https://issues.apache.org/jira/browse/SOLR-6122
Description
This PR implemented a new overseer level message handler to cancel submitted & in-progress collections api calls. As an example, this PR only opt-in backup collection api for in-progress cancel.
in-progress collections api calls are not complete, as core level cancel is not implemented. Current implemention removes tracking of in-progress collections api from overseers, which can be useful in some situation like backup.
Solution
General flow:
-> Client request cancle with async ID through
http://localhost:8983/solr/admin/collections?action=CANCEL&requestid=1
-> Cancel message handled by
OverseerCancelMessageHandler
to determine if this asyncId exist and if it's currently in submitted or in-progress state :workQueue
and clearblockedTasks
in case submitted task is in blocked tasksisInProgressCancelable
-> remove in-progress tasks from tracking queues in overseerworkQueue
&runningMap
&runningTasks
Api:
New V2 api interface for cancel handler
Overseer:
OverseerTaskQueue
to handle remove / get item from queue given zk pathOverseerCancelMessageHandler:
Tests
Test locally through CURL, working on testing
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.