Skip to content

Update gradle to 8.14.3 - #3647

Closed
janhoy wants to merge 4 commits into
apache:mainfrom
janhoy:update-gradle
Closed

Update gradle to 8.14.3#3647
janhoy wants to merge 4 commits into
apache:mainfrom
janhoy:update-gradle

Conversation

@janhoy

@janhoy janhoy commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Supports Java 24, so we can then add matrix of JDK versions to run the BATS tests for.
I suppose we need to go to gradle 9 to get JDK 25 support eventually, but this is a stepping stone.

@github-actions github-actions Bot added dependencies Dependency upgrades tool:build labels Sep 10, 2025
@janhoy
janhoy marked this pull request as draft September 10, 2025 09:46
@janhoy

janhoy commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Enabled BATS run on JDK24 but our build is not yet compatible...

@dsmiley

dsmiley commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Question: did you take anything from Lucene's same upgrade? We share the same build infra... granted it grows increasingly divergent.

@janhoy

janhoy commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Nope, just a quick attempt. Makes sense to peek at their pr if they already upgraded.

@janhoy

janhoy commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

See apache/lucene#14591 for Lucene's upgrade PR.

@janhoy

janhoy commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Looks like we need to upgrade errorProne to be able to compile Solr under JDK24?

> Task :solr:api:compileJava
error: An unhandled exception was thrown by the Error Prone static analysis plugin.
     Please report this at https://github.com/google/error-prone/issues/new and include the following:
  
     error-prone version: 2.31.0
     BugPattern: (see stack trace)
     Stack Trace:
     java.lang.NoSuchFieldError: Class com.sun.tools.javac.code.TypeTag does not have member field 'com.sun.tools.javac.code.TypeTag UNKNOWN'
  	at com.google.errorprone.util.ASTHelpers.<clinit>(ASTHelpers.java:1301)
  	at com.google.errorprone.bugpatterns.PackageInfo.matchCompilationUnit(PackageInfo.java:39)
  	at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:449)

@malliaridis

Copy link
Copy Markdown
Contributor

Looks like we need to upgrade errorProne to be able to compile Solr under JDK24?

We are 10 minor versions behind and a lot of new checks have been added. Would be a good idea to update it first.

But for backporting we should take this information into account (we might not be able to backport to 9.x).

@janhoy

janhoy commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Yes, I'm aware that 9.x needs to stay on 2.31. I have started to adapt #3116 with the missing rules..

runs-on: ubuntu-latest
timeout-minutes: 40

strategy:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should leave multi-JDK testing to Jenkins, and keep these GHA CI for PRs where we don't need to test multi-JDK. The likelihood of breaking another JDK is small, and wouldn't be specific to the bats tests.

@janhoy janhoy closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency upgrades tool:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants